Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: make userDataDir configurable #567

Open
DanielRuf opened this issue Aug 7, 2024 · 2 comments · May be fixed by #630
Open

v4: make userDataDir configurable #567

DanielRuf opened this issue Aug 7, 2024 · 2 comments · May be fixed by #630
Assignees
@jszuminski
Labels
enhancement

Comments

@DanielRuf
Copy link

Depending on the context in which the CLI is started, the path results in a different absolute path.

Please make this configurable to prevent, that it creates the tmp folder in the wrong place.

https://github.com/highcharts/node-export-server/blob/master/lib/browser.js#L69
@jszuminski jszuminski self-assigned this Aug 13, 2024
@jszuminski
Copy link
Contributor

Thanks for reporting @DanielRuf! I've added it to our backlog and will try to make it a part of the next minor release.

jszuminski added a commit that referenced this issue Aug 13, 2024
@jszuminski
Added #567, PUPPETEER_DIR made configurable.
c6f7462
@jszuminski jszuminski mentioned this issue Aug 13, 2024
Closed
5 tasks
jszuminski added a commit that referenced this issue Aug 13, 2024
@jszuminski
Update CHANGELOG.md with #567.
05c0f93
@jszuminski jszuminski linked a pull request Aug 21, 2024 that will close this issue
feat/567-user-data-dir-config #569
Closed
5 tasks
@jszuminski
Copy link
Contributor

@DanielRuf feel free to test out this pull request and let me know if that's what you were looking for.

PaulDalek added a commit that referenced this issue Feb 10, 2025
@PaulDalek
Added the PUPPETEER_TEMP_DIR option, touch #567.
ac4fd60
@PaulDalek PaulDalek linked a pull request Feb 10, 2025 that will close this issue
Open
@PaulDalek PaulDalek removed a link to a pull request Feb 10, 2025
feat/567-user-data-dir-config #569
Closed
5 tasks
PaulDalek added a commit that referenced this issue Feb 10, 2025
@PaulDalek
Simplfiied validator, touch #567.
eb2b507
@PaulDalek PaulDalek linked a pull request Feb 10, 2025 that will close this issue
567/user-data-dir-config #630
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jszuminski jszuminski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

567/user-data-dir-config highcharts/node-export-server
2 participants
@DanielRuf @jszuminski