Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the todolist example to remove the frees dependency #4: Part 2 -- the rest of the changes #12

Merged
merged 19 commits into from
Jul 8, 2020

Conversation

dmarticus
Copy link

@dmarticus dmarticus commented Jul 2, 2020

Closes #4

@dmarticus
Copy link
Author

Hmmm going to leave this in WIP mode because even though all the checks are green I got an IOException for the DB connection when running it locally; which I'll look into after lunch. I think I wrote one of my queries wrong.

@dmarticus
Copy link
Author

Woohoo the app runs and the DB connection has been refactored! I'm promoting this PR from "draft" status to "ready for review" :)

@dmarticus dmarticus marked this pull request as ready for review July 2, 2020 21:33
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but overall the PR looks good to me

@dmarticus
Copy link
Author

thanks for the review, @fedefernandez! I was out on Friday for the US holiday last week so I'll address your comments today :)

@dmarticus dmarticus force-pushed the dylan/issue4-rewrite-todolist-lib branch from 9f0a008 to 6223cd0 Compare July 6, 2020 15:42
@cb372
Copy link
Member

cb372 commented Jul 8, 2020

I think this is probably fine but it's a bit hard to review with your other branch merged into it. Maybe merge your other PR first, then rebase this one against master?

Copy link
Author

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine but it's a bit hard to review with your other branch merged into it. Maybe merge your other PR first, then rebase this one against master?

Yeah I agree and sorry for the headache. Just rebased; the PR should look cleaner now.

project/ProjectPlugin.scala Outdated Show resolved Hide resolved
@dmarticus dmarticus merged commit 821c567 into master Jul 8, 2020
@fedefernandez fedefernandez deleted the dylan/issue4-rewrite-todolist-lib branch January 19, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite the todolist example to remove the frees dependency
3 participants