Update all examples to use sbt-mu-srcgen #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2020 12:01
…nly supports one per app; deleting the rest of the hand-written scala code for the seed app
…ome weird behavior between monix and FS2 (the example kinda used both)
dmarticus
changed the title
dmarticus
commented
Jul 11, 2020
routeguide/server/src/main/scala/handlers/RouteGuideServiceHandler.scala
Outdated
Show resolved
Hide resolved
dmarticus
changed the title
juanpedromoreno
requested changes
Jul 14, 2020
routeguide/client/src/main/scala/handlers/RouteGuideClientHandler.scala
Outdated
Show resolved
Hide resolved
routeguide/client/src/main/scala/handlers/RouteGuideClientHandler.scala
Outdated
Show resolved
Hide resolved
routeguide/client/src/main/scala/handlers/RouteGuideClientHandler.scala
Outdated
Show resolved
Hide resolved
routeguide/server/src/main/scala/handlers/RouteGuideServiceHandler.scala
Outdated
Show resolved
Hide resolved
routeguide/server/src/main/scala/handlers/RouteGuideServiceHandler.scala
Outdated
Show resolved
Hide resolved
routeguide/server/src/main/scala/handlers/RouteGuideServiceHandler.scala
Outdated
Show resolved
Hide resolved
seed/client/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Outdated
Show resolved
Hide resolved
seed/client/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Juan Pedro Moreno <[email protected]>
Co-authored-by: Juan Pedro Moreno <[email protected]>
Co-authored-by: Juan Pedro Moreno <[email protected]>
Co-authored-by: Juan Pedro Moreno <[email protected]>
…rged in without checking
|
@juanpedromoreno I think I got everything! Sorry for being super non-diligent about picking up the |
seed/client/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Outdated
Show resolved
Hide resolved
juanpedromoreno
approved these changes
Jul 17, 2020
seed/client/src/main/scala/example/seed/client/process/ProtoPeopleServiceClient.scala
Outdated
Show resolved
Hide resolved
added 3 commits
July 17, 2020 11:25
…etOrElse calls invoke those errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.
This PR covers every example except for the todolist, which is a pretty significant chunk that may be worth a separate PR just because of all the hand-written Scala code that it contains. If folks want it to go out in this PR then I can move this task back into WIP.