New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the HTTP-related code in serviceImpl.scala #844

Closed

cb372 opened this issue Mar 13, 2020 · 1 comment · Fixed by #887

Member

cb372 commented Mar 13, 2020

mu-scala/modules/internal/src/main/scala/higherkindness/mu/rpc/internal/serviceImpl.scala

Lines 597 to 598 in 725e46f

    
           // TODO not sure what the following line is doing, as the result is not used. Is it needed? 
        
           _      <- findAnnotation(d.mods, "http").collect({ case Apply(_, args) => args }).toList

Member Author

cb372 commented Mar 16, 2020

Probably not worth doing until after #849

cb372 mentioned this issue

Refactor the @service macro #887

Merged

cb372 closed this as completed in #887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment