Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a more reliable ABI validator #80

Open
pfletcherhill opened this issue Apr 13, 2018 · 0 comments
Open

Make a more reliable ABI validator #80

pfletcherhill opened this issue Apr 13, 2018 · 0 comments

Comments

@pfletcherhill
Copy link
Member

Because encodeSignature requires its argument to have both a name and a type, just checking that all inputs have those works for now. However, it might make sense to tell the user that their ABI is invalid, if they pass an ABI with an entry that is of type function but lacks a name. It seems only constructor and fallback types are allowed to miss name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant