Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety added to the project #77

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VaishnaviSood
Copy link

@VaishnaviSood VaishnaviSood commented Mar 9, 2021

Migrated the dependencies to null-safety (adobe_xd and razorpay_flutter are not compatible with null safety which caused problems). So now the project is not sound null safe. It is a type of mixed version. I thoroughly checked the code for non-nullable and nullable types and edited the code accordingly. If there is any issue regarding it, please inform..
Closes #64

@himanshusharma89
Copy link
Owner

@VaishnaviSood Was there a requirement to update the environment SDK? And can you attach a gif of the checkout window on the cart screen, so that I can verify that Razorpay is still working along with the Adobe XD.

@himanshusharma89 himanshusharma89 added Level3 hard gssoc issue GSSOC21 Issues created for GSSOC'21 labels Mar 9, 2021
@himanshusharma89
Copy link
Owner

@VaishnaviSood Was there a requirement to update the environment SDK? And can you attach a gif of the checkout window on the cart screen, so that I can verify that Razorpay is still working along with the Adobe XD.

@VaishnaviSood do response whenever you can because I would like to merge this PR as soon as possible.

@VaishnaviSood
Copy link
Author

Firstly sorry for the late reply... and yes it was a requirement to update the SDK as the latest version of Dart supports null safety.
Razorpay is working fine.....but I guess the only problem now is that app would not run...we have to run the app by command 'flutter run --no-sound-null-safety', because the app is not sound null safe.
I hope the video would demonstrate working of razorpay.

WhatsApp.Video.2021-03-09.at.11.44.38.PM.mp4

@himanshusharma89
Copy link
Owner

Okay @VaishnaviSood thanks for the update, let the PR exists until we somewhat finalise this app. You can create the null safety issue in these plugins as I told you earlier. And you can proceed with other issues. I'll let you know when to update this PR.

@himanshusharma89
Copy link
Owner

@VaishnaviSood I am converting this PR to draft. I'll try to release the null safety version of Razorpay as soon as possible to make the project sound null safe.

@himanshusharma89 himanshusharma89 marked this pull request as draft March 12, 2021 14:23
@VaishnaviSood
Copy link
Author

ohkay!...That's good...but the adobe_xd package also did not have a null safe version. If you could do something about that. And do inform me when its all done..I'll make the required changes

@himanshusharma89
Copy link
Owner

ohkay!...That's good...but the adobe_xd package also did not have a null safe version. If you could do something about that. And do inform me when its all done..I'll make the required changes

I think we can remove the adobe_xd, I'll check it and update you soon.

@himanshusharma89 himanshusharma89 removed GSSOC21 Issues created for GSSOC'21 Level3 hard gssoc issue labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the app to Null Safety
2 participants