From f1894f67fd467a288bfd567b78614e8a5d2f95e0 Mon Sep 17 00:00:00 2001 From: Thomas Chou Date: Sun, 25 Feb 2024 09:17:54 -0800 Subject: [PATCH] encoder: esp32 no need to pull up There is default pull down in the ESP32Encoder lib. Signed-off-by: Thomas Chou --- firmware/lib/encoder/encoder.h | 1 - 1 file changed, 1 deletion(-) diff --git a/firmware/lib/encoder/encoder.h b/firmware/lib/encoder/encoder.h index 9fa6fc48..477e4979 100644 --- a/firmware/lib/encoder/encoder.h +++ b/firmware/lib/encoder/encoder.h @@ -49,7 +49,6 @@ class Encoder pin2 = temp_pin; } counts_per_rev_ = counts_per_rev; - ESP32Encoder::useInternalWeakPullResistors = UP; encoder_.attachHalfQuad(pin1, pin2); } float getRPM() {