Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplcate error 'the order cannot be filled' #96

Open
primersion opened this issue Feb 15, 2025 · 1 comment
Open

Duplcate error 'the order cannot be filled' #96

primersion opened this issue Feb 15, 2025 · 1 comment

Comments

@primersion
Copy link
Contributor

primersion commented Feb 15, 2025

When selling small amounts of a token on the market, this may result in a calculated quantity of 0, in which case the market contract loops over every buy order and ouputs 'the order cannot be filled' multiple times. See https://he.dtools.dev/tx/b0086b1bef1fcc7dd40cabd6c32d6a90f1a93c6a-0 for an example.

@Endecs
Copy link

Endecs commented Feb 21, 2025

With my change in PR91 this should at least decrease the number of attempts to 25.
For sure forther investigation should be taken to the contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants