Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Return token list ordered by 24h from GraphQL #190

Open
lion-200 opened this issue Nov 21, 2019 · 2 comments
Open

Feature: Return token list ordered by 24h from GraphQL #190

lion-200 opened this issue Nov 21, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request front-end Tasks relating to the front-end

Comments

@lion-200
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In the old DEX the tokens were default sorted by 24h volume descending. Currently graphql doesn't return tokens in that order.

Describe the solution you'd like
Return tokens by default ordered by 24h descending.

image

image

@lion-200 lion-200 added enhancement New feature or request front-end Tasks relating to the front-end labels Nov 21, 2019
@Vheissu
Copy link
Contributor

Vheissu commented Dec 3, 2019

@lion-200 Something tells me the old DEX was sorting the tokens on the client-side. Nothing I could see in the code suggests it was done during the call to the API. I will, however, make the GraphQL API return the results ordered by 24h.

@Vheissu
Copy link
Contributor

Vheissu commented Dec 12, 2019

The only solution right now is to return 1000 tokens which are sorted by volume. it's not an ideal solution whatsoever because to properly sort it, you need to request the 1000 tokens and 1000 metrics. We need a server-side index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end Tasks relating to the front-end
Projects
None yet
Development

No branches or pull requests

2 participants