Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow editing merge tag attributes in the editor #851

Open
picocodes opened this issue May 31, 2024 · 1 comment
Open

[FEATURE] Allow editing merge tag attributes in the editor #851

picocodes opened this issue May 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@picocodes
Copy link
Collaborator

Description

Most merge tags accept attributes such as format and default values. Provide a way to display this in the email editor.

Describe the solution you'd like

Most merge tags that are shown as blocks allow editing this merge tags. For other tags we can add something such as a merge editor popup that displays the available fields.

Screenshots

No response

Additional information

No response

@picocodes picocodes added the enhancement New feature or request label May 31, 2024
@scrobbleme
Copy link

scrobbleme commented Aug 20, 2024

Maybe switch to "Block Bindings" for merge tags (where possible)?
This would allow using the default styling options.

As of now, you have to insert Block Bindings manually (i.e. the enhanced paragraph block), but as you are already familiar with extending Gutenberg, you maybe could add some function for this.

Block Bindings itself are easy to implement and use.

Example:

<!-- wp:paragraph {
"metadata":{
    "name":  "Noptin: Name",
    "bindings":{"content":{
        "source":"noption/merge_tag",
        "args":{
            "key":"name"
            }
        }}}, 
"className":"text-decoration-none","fontSize":"small"} -->
<p class="text-decoration-none has-small-font-size">Noptin: Name</p>
<!-- /wp:paragraph -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants