Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expoential Retry Backoff Timer #421

Closed
spidercensus opened this issue Oct 20, 2023 · 1 comment
Closed

Expoential Retry Backoff Timer #421

spidercensus opened this issue Oct 20, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request invalid This doesn't seem right wontfix This will not be worked on

Comments

@spidercensus
Copy link

Is your feature request related to a problem? Please describe:
I'm sure you're aware of the many people encountering rate-limiting while using this myQ library. In one of these issues, I suggested adding an exponential back-off timer in order to slow down clients, because there is currently no back-off timer at all in this libray.

Describe the solution you'd like:
The retry Promise will implement a sleep timer that exponentially increases with each retry.

Describe alternatives you've considered:
A static or random back-off timer would also be somewhat useful, but given that we don't really understand the timing that leads to lock-outs, exponential will solve the problem better.

Additional context:
Look at all of the first dozen issues on this page which were summarily closed without resolution by project maintainers.

@spidercensus spidercensus added the enhancement New feature or request label Oct 20, 2023
@hjdhjd
Copy link
Owner

hjdhjd commented Oct 20, 2023

Please review prior issues related to this. The short answer is no. You proceed from an invalid assumption, though understandable, around what the 429 means in this context. Please review the prior issues related to this.

@hjdhjd hjdhjd closed this as completed Oct 20, 2023
Repository owner locked and limited conversation to collaborators Oct 20, 2023
@hjdhjd hjdhjd added duplicate This issue or pull request already exists invalid This doesn't seem right wontfix This will not be worked on labels Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists enhancement New feature or request invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants