Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_full_complex_autocorrelations function #273

Open
gianmarco-terrones opened this issue Oct 23, 2024 · 1 comment
Open

generate_full_complex_autocorrelations function #273

gianmarco-terrones opened this issue Oct 23, 2024 · 1 comment

Comments

@gianmarco-terrones
Copy link
Contributor

Two versions of generate_full_complex_autocorrelations are in molSimplify. One is at molSimplify.Informatics.lacRACAssemble, and the other at molSimplify.Informatics.autocorrelation. The functions are very similar, so I think one should be removed to adhere to the DRY principle.
@gianmarco-terrones
Copy link
Contributor Author

In fact, many of the functions in lacRACAssemble.py seem to have counterparts (with the same name and nearly the same lines of code) in autocorrelation.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gianmarco-terrones