-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Chrome on Android #11
base: master
Are you sure you want to change the base?
Conversation
Most of the times this application will be used when testing and debugging locally which doesnt happen on https most of the times. Issue #5 focusses on mobile debugging, a technique used to debug on mobile using Desktop. It is for that that we need Desktop Notifications to occur. |
@hkirat It fixes #5 in that the web notifications are created on the Android device, which is what we want. For example, you create a JS Bin demo that uses Regarding remote debugging, there is no need for this tool to work with it. As I've mentioned in #5, notification-logger is an alternative to remote debugging, in scenarios where the developer doesn't want to go through the hassle of connecting the device via USB just to view console messages. So, when remote-debugging a web page, the developer will view console messages in the actual DevTools Console on desktop normally; and when viewing/debugging the page on the device itself, the developer will see console messages as web notifications with @jarifibrahim's fix. |
ok Great! |
@hkirat There's no fix for the https problem. The notification does not work over http. Try it over http and see the console. You've merged my last PR (notification-icon) and hence that commit is no more in this PR. Github takes care of this stuff. I can see only one commit in this PR. |
@jarifibrahim Yes I was going through this |
@hkirat Is this fix still valid? I can resolve the merge conflicts. I am sorry it took me so long to reply. I somehow lost track of this PR :) |
I've created a test repo for demonstration - https://jarifibrahim.github.io/test/
The notification works on Chrome desktop and android. The only catch is for android notifications to work, the website should be
https
.This fixes #5