Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key duplicates #24

Open
KillTheMule opened this issue Nov 25, 2018 · 2 comments
Open

Key duplicates #24

KillTheMule opened this issue Nov 25, 2018 · 2 comments

Comments

@KillTheMule
Copy link
Contributor

So, I have pretty extensive menus, and one or two of them are so large that two menu items get assigned the same key. That's quite a bit of a problem, but I only noticed some time during debugging something else. I understand you can't provide sensible choices (or different choices at all) for all menu sizes, but could you maybe throw an error if that happens so it gets noticed?

@hkupty
Copy link
Owner

hkupty commented Nov 25, 2018

I'll double check. The default behavior was to pick any unassigned key. The range of possibilities would be around 80 entries.

It should never repeat. What should happen instead is that the first missing key would be nil, thus erroring.

I'll investigate further and I think this calls up for setting a test infrastructure to avoid regressions.

@KillTheMule
Copy link
Contributor Author

... and I think this calls up for setting a test infrastructure to avoid regressions.

I once wrote a blog post about that. If you're interested, I can set this up.

@hkupty hkupty mentioned this issue Nov 26, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants