Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ac_atan2_cordic - range of angle #9

Open
smirre111 opened this issue Nov 18, 2021 · 0 comments
Open

ac_atan2_cordic - range of angle #9

smirre111 opened this issue Nov 18, 2021 · 0 comments

Comments

@smirre111
Copy link

The ac_atan2_cordic implementation calculates an angle in range [-M_PI, M_PI).
While this is nice and correct, in hardware it makes much more sense to scale the angle to be in the range of [-1, 1).

With that, the natural periodicity of the angle/phase is guaranteed and the number range is used with 100% efficiency.

A template parameter could allow scaling of the LUT and other impacted constants by M_PI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant