Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many ac_float operators don't compile, are missing a return *this #5

Open
wickedfoo opened this issue Dec 5, 2018 · 1 comment
Open

Many ac_float operators don't compile, are missing a return *this #5

wickedfoo opened this issue Dec 5, 2018 · 1 comment

Comments

@wickedfoo
Copy link

e.g., ac_float operator +=(const AC_FL(2) &op2):

https://github.com/hlslibs/ac_types/blob/master/include/ac_float.h#L656

returns

 error: control reaches end of non-void function
      [-Werror,-Wreturn-type]
@wickedfoo wickedfoo changed the title Many operators don't compile, are missing a return *this Many ac_float operators don't compile, are missing a return *this Dec 5, 2018
@cmarqu
Copy link

cmarqu commented Apr 14, 2020

This appears to have been fixed in 74664af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmarqu @wickedfoo