Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of primary selections depends on "automatic commands" option #2651

Closed
weiss opened this issue Mar 22, 2024 · 2 comments · Fixed by #2681
Closed

Handling of primary selections depends on "automatic commands" option #2651

weiss opened this issue Mar 22, 2024 · 2 comments · Fixed by #2681
Labels

Comments

@weiss
Copy link

weiss commented Mar 22, 2024

Describe the bug
For primary selections to be stored in the history, it seems the Run automatic commands on selection (run_selection) option must be enabled in addition to the Store text selected using mouse (check_selection) option.

To Reproduce

copyq config check_selection true
copyq config run_selection false

Then select a few items with the mouse, and see how those weren't added to the history:

copyq read 0 1

Expected behavior
I'd expect copyq read 0 1 to list items selected with the mouse regardless of the copyq config run_selection value.

Version, OS and Environment
CopyQ Clipboard Manager 6.4.0
Qt: 5.15.8
KNotifications: 5.101.0
Compiler: GCC
Arch: x86_64-little_endian-lp64
OS: Debian GNU/Linux 12 (bookworm)

I was able to reproduce the behavior both on Wayland and X11.

@weiss weiss added the bug label Mar 22, 2024
@hanschen
Copy link

hanschen commented Apr 4, 2024

Nice find, this explains why primary selection wasn't working for me. Can confirm on:

Version, OS and Environment
CopyQ Clipboard Manager 8.0.0
Qt: 5.15.12
KNotifications: 5.115.0
Compiler: GCC
Arch: x86_64-little_endian-lp64
OS: Arch Linux

hluk added a commit that referenced this issue Apr 18, 2024
Fixes storing selection when "Store text selected using mouse" option is
enabled but "Run automatic commands on selection" is disabled.

Fixes #2651
hluk added a commit that referenced this issue Apr 21, 2024
Fixes storing selection when "Store text selected using mouse" option is
enabled but "Run automatic commands on selection" is disabled.

Fixes #2651
hluk added a commit that referenced this issue Apr 21, 2024
Fixes storing selection when "Store text selected using mouse" option is
enabled but "Run automatic commands on selection" is disabled.

Fixes #2651
@hluk
Copy link
Owner

hluk commented Apr 21, 2024

Fixed in #2681 (it will be available in the next release). Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants