Prevent endless subordinate entity loops

tobiaspc · tobiaspc · commit d7e638f4a50e · 2024-12-10T18:59:18.000+01:00
diff --git a/src/ofcli/fedtree.py b/src/ofcli/fedtree.py
@@ -37,6 +37,8 @@ async def discover(self, http_session: aiohttp.ClientSession) -> None:
                             entity_id=URL(sub), http_session=http_session
                         )
                     )
+                    if subordinate.entity.get('sub') == self.entity.get('sub'):
+                        raise InternalException(f"Entity is listed as its own subordinate.")
                     await subordinate.discover(http_session)
                     # logger.debug(f"Adding subordinate {subordinate.entity.get('sub')}")
                     # logger.debug(f"{subordinate.entity}")

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ async def discover(self, http_session: aiohttp.ClientSession) -> None:`
`37`	`37`	`entity_id=URL(sub), http_session=http_session`
`38`	`38`	`)`
`39`	`39`	`)`
	`40`	`+ if subordinate.entity.get('sub') == self.entity.get('sub'):`
	`41`	`+ raise InternalException(f"Entity is listed as its own subordinate.")`
`40`	`42`	`await subordinate.discover(http_session)`
`41`	`43`	`# logger.debug(f"Adding subordinate {subordinate.entity.get('sub')}")`
`42`	`44`	`# logger.debug(f"{subordinate.entity}")`