Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowners output incomplete in (non-main) git worktree #27

Open
HarryWeppner opened this issue May 30, 2024 · 1 comment
Open

codeowners output incomplete in (non-main) git worktree #27

HarryWeppner opened this issue May 30, 2024 · 1 comment

Comments

@HarryWeppner
Copy link

It appears that codeowners assumes it is running in the main work tree. When run in a non-main work tree, its results differ vastly from those in the main work tree. In the non-main work tree, I only see three unowned dot-files while there are thousands of unowned files in the main work tree.

@rwese
Copy link

rwese commented Jun 1, 2024

If you could provide a simple example to reproduce this state it would be nice.

What I can tell is that the current implementation does no detection of any git related information, stepping down into a lower directory where a new CODEOWNERS file might by applicable is not implemented, if we assume it works like .gitignore they would add their matches, overwriting the owner for the matching rule.

In my screenshot you can see that the 'root' cmd folder matches, but the added worktree doesn't.
Screenshot 2024-06-01 at 06 08 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants