Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down the number of overlapping associations somehow #6

Open
youngchanpark opened this issue May 28, 2021 · 2 comments
Open

Trim down the number of overlapping associations somehow #6

youngchanpark opened this issue May 28, 2021 · 2 comments
Milestone

Comments

@youngchanpark
Copy link
Member

Since the number of GWAS studies have grown, we get massive amounts of overlapping associations in our plots.

Two examples below.

image

image

Think of a strategy to trim down the associations.

@agilly
Copy link
Member

agilly commented May 28, 2021

Urgent/Quick fix:

  • Add a button to disable previous associations

Long-term:
For the below, these are suggestions, it will depend on how the plots look.

  • Use point-level graphics (e.g. different symbol or highlight ring?) instead of rays
  • Use rays only for variants not in our dataset? Or add variants not in dataset with different symbol?

@youngchanpark
Copy link
Member Author

Completely disabled the red lines for now (#12).

After looking at the plot with the red ray disabled, it appears that @agilly your first suggestion seems to already be implemented.

Will look into Bokeh's legend and widget functionality to see whether we can enable/disable certain rays.
https://docs.bokeh.org/en/latest/docs/user_guide/interaction/legends.html
https://docs.bokeh.org/en/latest/docs/user_guide/interaction/widgets.html

A suggestion on top of your second suggestion, how about differently coloured ray for previously associated variant that's in our dataset? So like red for prev assoc position not in our dataset and blue ray for prev assoc variant present in our dataset.

@youngchanpark youngchanpark added this to the v1.0.0 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants