Misuv 8840 #2665
Misuv 8840 #2665
Conversation
|
| @(viewModel: ReportingFrequencyViewModel)(implicit messages: Messages, user: auth.MtdItUser[_]) | ||
| @(viewModel: ReportingFrequencyViewModel)(implicit messages: Messages, user: auth.MtdItUser[_], dateService: DateServiceInterface) | ||
|
|
||
| @optInLink = { |
There was a problem hiding this comment.
If we can avoid usage of .get over Option and .head over List; you should be able to move this behaviour on the view model level;
| @linkComponent(url, message = messages("reporting.frequency.manageReportingFrequency.optOut.link.generic")) | ||
| } else if (viewModel.optOutTaxYears.size == 1 && viewModel.optOutTaxYears.head == dateService.getCurrentTaxYear.nextYear) { | ||
| @linkComponent(url, message = messages("reporting.frequency.manageReportingFrequency.optOut.link.onwards", viewModel.optOutTaxYears.head.startYear.toString, viewModel.optOutTaxYears.head.endYear.toString)) | ||
| } else if (viewModel.optOutTaxYears.size == 1) { | ||
| @linkComponent(url, message = messages("reporting.frequency.manageReportingFrequency.optOut.link.taxyear", viewModel.optOutTaxYears.head.startYear.toString, viewModel.optOutTaxYears.head.endYear.toString)) |
There was a problem hiding this comment.
Is there a consensus on what order the bullet points should be? Currently on the PR the Quarterly + Annual scenario has the Opt in to 2025-26 first with the Opt out 2024-25 second.
I'm only asking because the ticket has it the other way around, and I wasn't sure if that mattered because the whole area would be dynamic, and it may be preferred for the bullet points to be in chronological order.
There was a problem hiding this comment.
Yeah I think the design team has done it in an order of which ever tax year comes first. But we could double check with them if that order is mandatory before the whole page completes.
No description provided.