-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3 support #103
Comments
Sorry, should have filed this earlier. @constantinpape is driving forward on v0.3 and it would be good to know one of:
~J. |
With a tiny fix in
the data is visible in vizarr: but, that data is chunked in 3D (instead of 2D as expected by vizarr), so we get some unexpected behaviour when trying to scroll through Z. |
❤️ Can that be a PR as well? |
Looking through the links, it's not totally clear to me what needs to be added to vizarr to support Something I need to think more deeply about is the variable dimension handling. Fortunately vizarr doesn't assume 5D, but some of the logic in the OME- loaders might assume this. We can just inspect the 3D chunking is still an issue and something we are thinking about. Adding support for volumetric rendering will likely entail extending the Tile 3D Layer from deck.gl. I should look into how other tools (like neuroglancer and napari) choose to render 2D multiscale from 3D downsampled datasets. As a side note, I notice that the example data does not have
My hope is to just bump to the latest version of Zarr.js (with support for |
Sorry - just started on this already... #104 |
No. And in fact that's what I was referring to with #103 (comment) (a general 👍 on the separate nested/flat PR(s)) |
Ah, sorry I missed reading that. My mistake. Vizarr probably needs some data-driven heuristic like napari to "guess" initial contrast limits for the sliders if rendering metadata isn't present. It's fallback is the full range of values for the dtype, which is not desirable (except for ref ( |
Thanks for taking the lead on the changes @will-moore! |
@manzt : we are getting close to merging the various PRs on the Python side. How are you feeling about a release here? Shall we try to coordinate the process? |
I'm happy to cut a corresponding |
cc: @will-moore @constantinpape @tischi @manzt
The text was updated successfully, but these errors were encountered: