New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 may not be URL safe #26

Open

Rohitrajak1807 opened this issue Jul 3, 2021 · 0 comments

Rohitrajak1807 commented Jul 3, 2021

javascript_playground/sharding/index.js

Line 65 in bc01f3c

const hash = crypto.createHash("sha256").update(url).digest("base64")

@hnasr base64 encoding used in the URL shortener may have a '/' un the URL_ID, so using digest('base64url') is advised to avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment