Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

startup issues with xnhns #3

Open
evbots opened this issue Apr 16, 2022 · 0 comments
Open

startup issues with xnhns #3

evbots opened this issue Apr 16, 2022 · 0 comments

Comments

@evbots
Copy link

evbots commented Apr 16, 2022

I'm trying to run through the initial setup locally. When running yarn deploy:test, I get:

📄 StablePriceOracle
HardhatError: HH700: Artifact for contract "StablePriceOracle" not found.
    at Artifacts._handleWrongArtifactForContractName (/Users/evan/code/xnhns/node_modules/hardhat/src/internal/artifacts.ts:473:11)
    at Artifacts._getArtifactPathFromFiles (/Users/evan/code/xnhns/node_modules/hardhat/src/internal/artifacts.ts:587:19)
    at Artifacts._getArtifactPath (/Users/evan/code/xnhns/node_modules/hardhat/src/internal/artifacts.ts:270:17)
    at Artifacts.readArtifact (/Users/evan/code/xnhns/node_modules/hardhat/src/internal/artifacts.ts:50:26)
    at getContractFactoryByName (/Users/evan/code/xnhns/node_modules/@nomiclabs/hardhat-ethers/src/internal/helpers.ts:100:20)
    at deploy (/Users/evan/code/xnhns/packages/hardhat/scripts/deploy-single-tld-ens.js:23:29)
    at main (/Users/evan/code/xnhns/packages/hardhat/scripts/deploy-single-tld-ens.js:46:3)
error Command failed with exit code 1.

I assume this because there's a contract called BasePriceOracle.sol. I change that in the deploy-single-tld-ens.js, and then get this error:

📄 BasePriceOracle
Error: invalid value for array
    at /Users/evan/code/xnhns/node_modules/@ethersproject/contracts/src.ts/index.ts:150:60
    at step (/Users/evan/code/xnhns/node_modules/@ethersproject/contracts/lib/index.js:48:23)
    at Object.next (/Users/evan/code/xnhns/node_modules/@ethersproject/contracts/lib/index.js:29:53)
    at /Users/evan/code/xnhns/node_modules/@ethersproject/contracts/lib/index.js:23:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/evan/code/xnhns/node_modules/@ethersproject/contracts/lib/index.js:19:12)
    at resolveAddresses (/Users/evan/code/xnhns/node_modules/@ethersproject/contracts/lib/index.js:109:12)
    at /Users/evan/code/xnhns/node_modules/@ethersproject/contracts/src.ts/index.ts:133:20
    at Array.map (<anonymous>)
    at /Users/evan/code/xnhns/node_modules/@ethersproject/contracts/src.ts/index.ts:132:44
error Command failed with exit code 1.

I assume this is choking on incorrect constructor params, so i change it to the following, per example in the .sol file comments:

await deploy('BasePriceOracle', [
    [1,10],
    [5,10]
  ])

After that the yarn deploy:test command completes successfully. should i make a PR with these changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant