Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] User editable player notes #2229

Closed
wsbrenk opened this issue Jan 13, 2025 · 1 comment
Closed

[FEATURE] User editable player notes #2229

wsbrenk opened this issue Jan 13, 2025 · 1 comment
Assignees
@wsbrenk
Labels
status: needs test might be fixed, needs test before closing
Milestone
9.0

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Jan 13, 2025

Feedback from HO forum:

Der_BierbaronOnline!
Lausitzer DefBreaker
Deutschland V.62
I'm no Supporter ;)
I mean a separat Note only in HO
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Jan 13, 2025

In training panel is a string area field called notes. In my current dev version it is not working correctly and those texts are not displayed in player overview table.

@wsbrenk wsbrenk self-assigned this Jan 13, 2025
@wsbrenk wsbrenk added this to the 9.0 milestone Jan 13, 2025
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jan 15, 2025
@wsbrenk
ho-dev#2229 Fix editing of player notes in training panel
bb66ff7
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jan 15, 2025
@wsbrenk
ho-dev#2229 Add column trainer notes to player overview table
2e3d56c
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jan 15, 2025
@wsbrenk
ho-dev#2229 remove wrong comment
3d76ebd
@wsbrenk wsbrenk mentioned this issue Jan 15, 2025
Merged
2 tasks
@wsbrenk wsbrenk added the status: needs review merge request is created and needs review of other developer label Jan 15, 2025
wsbrenk added a commit to wsbrenk/HO that referenced this issue Jan 17, 2025
@wsbrenk
ho-dev#2229 ReInit player overview table
d942474
wsbrenk added a commit that referenced this issue Jan 17, 2025
@wsbrenk
#2229 Add column trainer notes to player overview table (#2231)
4b7e021 
* remove unused YouthTableSorter.java

* #2229 Fix editing of player notes in training panel

* #2229 Add column trainer notes to player overview table

* #2229 remove wrong comment

* #2229 ReInit player overview table
@wsbrenk wsbrenk added status: needs test might be fixed, needs test before closing and removed status: needs review merge request is created and needs review of other developer labels Jan 17, 2025
@wsbrenk wsbrenk closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsbrenk wsbrenk

Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Milestone
9.0
Development

No branches or pull requests
1 participant
@wsbrenk