Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation before deleting item #776

Closed
1 task done
bverkron opened this issue Dec 27, 2024 · 2 comments
Closed
1 task done

Confirmation before deleting item #776

bverkron opened this issue Dec 27, 2024 · 2 comments
Assignees
Labels
feature request New feature or request good first issue Good for newcomers UI/UX

Comments

@bverkron
Copy link

bverkron commented Dec 27, 2024

Describe the feature you'd like

Seems there is currently no confirmation required before deleting an item. This could be catastrophic if an item is deleted accidentally and the original source of the item is no longer available on the web and can't be re-added.

Describe the benefits this would bring to existing Hoarder users

Avoids accidental and permanent deletion of an item that can no longer be found online

Can the goal of this request already be achieved via other means?

Not AFAIK.

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

Additional context

No response

@MohamedBassem MohamedBassem added feature request New feature or request UI/UX good first issue Good for newcomers labels Dec 28, 2024
@lexafaxine
Copy link
Contributor

lexafaxine commented Dec 30, 2024

Hello @MohamedBassem , I just found this repo and very interested in its concept. I am going to add a DeleteBookmarkConfirmationDialog component in the bookmarks components for web and add an alert for mobile to handle this. I could open a PR in 24h, could you please assign this issue to me? Thanks!

@MohamedBassem
Copy link
Collaborator

@lexafaxine thanks for picking this up, looking forward to the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers UI/UX
Projects
None yet
Development

No branches or pull requests

3 participants