Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable password change if password login is disabled #784

Open
1 task done
Kogoro opened this issue Dec 28, 2024 · 4 comments
Open
1 task done

Disable password change if password login is disabled #784

Kogoro opened this issue Dec 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Kogoro
Copy link

Kogoro commented Dec 28, 2024

Describe the feature you'd like

When using an OAuth provider and disabling the password based login, I would expect that the change password form in the settings page is also disabled.

Describe the benefits this would bring to existing Hoarder users

Consistent behavior with oauth provider.

Can the goal of this request already be achieved via other means?

An alternative would be a separate environment variable for the like for signup or password-based login. Nevertheless, I would not think that it would be that great.

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

Additional context

First time user and therefore there is a possibility that I did not find the correct information. In this case, excuse my foolish request.

@kamtschatka
Copy link
Contributor

I already tried to add that before, but it was patched out(cd07adb), so looks like this is intended

@MohamedBassem
Copy link
Collaborator

@kamtschatka that commit that you're pointing at only removes the message as it didn't look good. The functionality of hiding the form remained. So, no. This is not expected or intentional and it's indeed a bug.

@MohamedBassem MohamedBassem added the bug Something isn't working label Dec 28, 2024
@kamtschatka
Copy link
Contributor

ok my bad, i thought that was the preparation to revert all of it.
But why would you intentionally keep users in the dark why they can't change their password or email address, when we already have users who struggle to find the most basic functionality in hoarder?

@MohamedBassem
Copy link
Collaborator

@kamtschatka When we get to it, we can decide how we want to communicate this to the users. We can also disable the "Save" button with a tooltip explaining why, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants