Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some decoding errors should be fetch errors #1

Open
hoichi opened this issue Jan 10, 2020 · 0 comments
Open

Some decoding errors should be fetch errors #1

hoichi opened this issue Jan 10, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@hoichi
Copy link
Owner

hoichi commented Jan 10, 2020

No effort is made to check, e.g., for status codes, so when the error response is a valid JSON, extracting that JSON doesn’t throw. What does throw is decoding, because the shape is wrong, so instead of `FetchError you get `DecodeError.

Possible remedies:

  • Check for the network status
  • Provide a separate JSON decoder for errors
@hoichi hoichi added the bug Something isn't working label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant