Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial: 0xcoreblock #14

Open
zolotokrylin opened this issue Feb 12, 2025 · 2 comments
Open

Trial: 0xcoreblock #14

zolotokrylin opened this issue Feb 12, 2025 · 2 comments

Comments

@zolotokrylin
Copy link
Member

I’d appreciate any guidance on how we can proceed for the next step.

Originally posted by @0xcoreblock in #684

@zolotokrylin
Copy link
Member Author

@0xcoreblock, you have authors the following PRs:

What went wrong

Code Quality and Reviews

You got many rejects.

Aim for solutions that work correctly 99.9% of the time. Be independent and thorough in your QA - reviewers are not QA team members but are there for a final safety check. We expect contributors to deliver bug-free software, understanding that perfection is an ideal. Stand firm in your solutions and avoid unnecessary revisions based on subjective feedback.
Ref: https://github.com/holdex/developers/blob/main/.github/CONTRIBUTING.md#code-quality-and-reviews

Code of Conduct
...
2. Ensure the quality of your work. It is a sign of poor ownership and lack of confidence when you expect someone to deal with your incomplete work.
Ref.: https://github.com/holdex/developers/blob/main/.github/CODE_OF_CONDUCT.md#code-of-conduct

What went well

You are proactive.

What's next

We cannot tolerate constant rejections. However, given your proactive approach, I can offer you the opportunity to open and merge another pull request (PR) where you take full responsibility for quality. It's important that this process doesn't consume too much of your peers.

We need independent contributors who can work asynchronously, merge quickly, and deliver solutions to business problems without creating operational challenges for others. Your goal should be to keep things simple for your colleagues and avoid complicating their work.

@zolotokrylin
Copy link
Member Author

cc: @markholdex leaving this issue on you. P.S. Refer to the above reply; let's keep it as a standard of our replies to all candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant