Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No window decorations on linux (wayland) #276

Open
d61b292b-2859-4ed6-8c7c-b7397ad8e351 opened this issue Aug 26, 2024 · 5 comments
Open

Comments

@d61b292b-2859-4ed6-8c7c-b7397ad8e351

Pear desktop apps start without window decorations (minimize/close buttons).

Preliminary research suggests that electron/chromium possibly do not support this at the moment on wayland.

Vscode (which I believe is an electron app) does launch with window decorations. So maybe setting some additional options could fix this.

@rafapaezbas
Copy link
Contributor

rafapaezbas commented Aug 27, 2024

by default, desktop applications dont have a window frame. To add it, use . See https://github.com/holepunchto/pear/blob/main/examples/desktop/index.html#L80, and notice https://github.com/holepunchto/pear/blob/main/examples/desktop/index.html#L55-L76

@d61b292b-2859-4ed6-8c7c-b7397ad8e351

Thanks! That worked.

Having native controls would be nicer if possible at all

Feel free to close if not planned

@d61b292b-2859-4ed6-8c7c-b7397ad8e351

I'm running into a problem when using the <pear-ctrl> web component.

When dragging the window around, the window width and height fluctuate by 1 pixel (can be seen when devtools are open).

This is barely noticeable, but after manually changing the size of the window the whole app window starts to glitch out while dragging the window around.

I can provide a video if you are unable to replicate it

@d61b292b-2859-4ed6-8c7c-b7397ad8e351

Happens with keet as well

@rafapaezbas
Copy link
Contributor

rafapaezbas commented Sep 27, 2024

@d61b292b-2859-4ed6-8c7c-b7397ad8e351 I tried to replicate on Ubuntu 22 but I could not. Could you please provide the video? It Would be very helpful to identify the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@rafapaezbas @d61b292b-2859-4ed6-8c7c-b7397ad8e351 and others