Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation when fetching results in unretrievable records, breaking multi-record queries #103

Closed
richard-fairthorne opened this issue Feb 10, 2019 · 3 comments

Comments

@richard-fairthorne
Copy link

I can't think of a rationale for being unable to retrieve records which do not validate.

When a fetch of, for example, 300 records has one record that cannot validate record, the app making the request will just fail.

Can we skip validation on db reads? Anything that can be inserted should be retrievable.

Possibly related: #36 and #37

@richard-fairthorne
Copy link
Author

richard-fairthorne commented Feb 10, 2019

After checking out #36 and #37 it seems to me that if it doesn't cause new issues, removing validation on query would eliminate a common cause of user confusion and issues.

@richard-fairthorne
Copy link
Author

A preliminary look through sqlHandler suggests to me that joi is only called when populating DB schemas. Am I right then to believe that this validation is actually taking place in jsonapi-server? I may be able to prioritize fixing this bug with a little nudging in the right direction.

This product got me going fast -- would love to contribute.

@richard-fairthorne
Copy link
Author

inactive

@richard-fairthorne richard-fairthorne closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant