Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usage of polished / inline color tweaks #1278

Open
gdbroman opened this issue Mar 24, 2023 · 1 comment
Open

Remove all usage of polished / inline color tweaks #1278

gdbroman opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
3:low priority refactor Improves code quality, doesn't change functionality.

Comments

@gdbroman
Copy link
Contributor

gdbroman commented Mar 24, 2023

Instead of doing specific contrast adjustments in multiple places I think we should aim to exclusively use our theme variables. We're not using all the theme-color variables fully – although some might need to be added too.

Because this sort of thing is hard to maintain:

CleanShot 2023-03-24 at 11 02 12@2x

And in the one-off cases we need dynamic contrast change, e.g. on :hover, we should do it in the styled-components markup to separate concerns (styling bloats component files), and preferably with pure CSS like filter: brightness(x) since it's slightly faster and we could get rid of the polished dependency.

CC: @drunkplato

@gdbroman gdbroman self-assigned this Mar 24, 2023
@gdbroman gdbroman added 3:low priority refactor Improves code quality, doesn't change functionality. labels Mar 24, 2023
@drunkplato
Copy link
Contributor

I am being forced to do this in the rebuilt-os-process branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3:low priority refactor Improves code quality, doesn't change functionality.
Projects
None yet
Development

No branches or pull requests

2 participants