You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of doing specific contrast adjustments in multiple places I think we should aim to exclusively use our theme variables. We're not using all the theme-color variables fully – although some might need to be added too.
Because this sort of thing is hard to maintain:
And in the one-off cases we need dynamic contrast change, e.g. on :hover, we should do it in the styled-components markup to separate concerns (styling bloats component files), and preferably with pure CSS like filter: brightness(x) since it's slightly faster and we could get rid of the polished dependency.
Instead of doing specific contrast adjustments in multiple places I think we should aim to exclusively use our theme variables. We're not using all the theme-color variables fully – although some might need to be added too.
Because this sort of thing is hard to maintain:
And in the one-off cases we need dynamic contrast change, e.g. on
:hover
, we should do it in the styled-components markup to separate concerns (styling bloats component files), and preferably with pure CSS likefilter: brightness(x)
since it's slightly faster and we could get rid of thepolished
dependency.CC: @drunkplato
The text was updated successfully, but these errors were encountered: