Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of error messages #1286

Open
ajlamarc opened this issue Mar 28, 2023 · 1 comment
Open

Better handling of error messages #1286

ajlamarc opened this issue Mar 28, 2023 · 1 comment
Labels
tech debt code should be refactored / restructured

Comments

@ajlamarc
Copy link
Contributor

Right now (esp. on the login screen) there's a lot of indirection / magic values being returned by the auth service's login method, and their usage on the login screen is similarly confusing.

This is generally discouraged - The full error should be thrown or returned and caught by the caller (as Electron permits). This will help us provide more explicit error messages to help with debugging for users.
@ajlamarc ajlamarc added the tech debt code should be refactored / restructured label Mar 28, 2023
@ajlamarc ajlamarc mentioned this issue Mar 28, 2023
Merged
@drunkplato
Copy link
Contributor

I am considering this in the refactor. Would like to jump on a call to discuss in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt code should be refactored / restructured
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drunkplato @ajlamarc