Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pion to v4 #108

Open
mattyg opened this issue Oct 11, 2024 · 2 comments · May be fixed by #109
Open

Bump pion to v4 #108

mattyg opened this issue Oct 11, 2024 · 2 comments · May be fixed by #109
Assignees
@neonphog

Comments

@mattyg
Copy link
Member

mattyg commented Oct 11, 2024 •
edited
Loading

pion/transport v3.0.2 includes a fix (workaround?) for android 11+ -- previous versions cannot connect to network interfaces (unless you use a fork of golang which p2p-shipyard is doing currently)

The fix commit in pion/transport: pion/transport@3ba6182

The original golang issue: golang/go#40569

The current workaround used by p2p-shipyard: https://github.com/darksoil-studio/p2p-shipyard/blob/e53bca77507eb808009b753b811aa9fc8ed32f0a/nix/modules/custom-go-compiler.nix#L66
@neonphog
Copy link
Collaborator

@mattyg - We're on v3.2.24:

tx5/crates/tx5-go-pion-sys/go.mod

Line 7 in 05e82a2

github.com/pion/webrtc/v3 v3.2.24

Did you mean bump to v4? That just stabilized today apparently! https://pkg.go.dev/github.com/pion/webrtc/v4?tab=versions

@mattyg
Copy link
Member Author

mattyg commented Oct 12, 2024

ah yes I guess I meant pion/transport v3.0.2 which is included in pion v4 -- so yeah that would be great to bump soon!

@mattyg mattyg changed the title Bump pion to v3 Bump pion to v4 Oct 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Holochain Oct 14, 2024
@neonphog neonphog self-assigned this Oct 15, 2024
@neonphog neonphog moved this from Backlog to In progress in Holochain Oct 15, 2024
@neonphog neonphog linked a pull request Oct 15, 2024 that will close this issue
Open
@neonphog neonphog moved this from In progress to Ready in Holochain Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neonphog neonphog

Labels
None yet
Projects
Holochain
Status: Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump to pion v4 holochain/tx5
2 participants
@mattyg @neonphog