Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #13

Open
maartenpaauw opened this issue Jun 8, 2020 · 6 comments · Fixed by #15
Open

Replace Travis CI with GitHub Actions #13

maartenpaauw opened this issue Jun 8, 2020 · 6 comments · Fixed by #15
Labels

Comments

@maartenpaauw
Copy link
Contributor

Title says all

@maartenpaauw maartenpaauw added the good first issue Good for newcomers label Jun 8, 2020
@neelkamath
Copy link
Contributor

I'll do it

@neelkamath
Copy link
Contributor

This issue is labeled as "hacktoberfest", but is ineligible for it:

Screen Shot 2020-10-04 at 10 59 40 AM

This is either because you need to re-add the hacktoberfest label (perhaps because you added it before October), or you need to add the hacktoberfest topic to your repo's topics temporarily.

@maartenpaauw
Copy link
Contributor Author

I've merged the PR but it is not working perfectly. The linter is now linting the workflow file and not the theme.

@neelkamath
Copy link
Contributor

@maartenpaauw change line 10 of the workflow to yamllint themes/template.yaml then. I wasn't sure whether you wanted to lint all YAML files or not.

@maartenpaauw
Copy link
Contributor Author

There is a .yamllint config file with configuration that points to the template.yaml file. It worked before with Travis CI. Not sure why its not working with GitHub actions.

@neelkamath
Copy link
Contributor

Ohh.
By the way, I seem to have forgotten to replace the Travis CI badge in the README with the GitHub Actions one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants