Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for zero height display on Squeezelite-ESP32 #331

Open
wizmo2 opened this issue May 29, 2024 · 2 comments
Open

Missing check for zero height display on Squeezelite-ESP32 #331

wizmo2 opened this issue May 29, 2024 · 2 comments

Comments

@wizmo2
Copy link

wizmo2 commented May 29, 2024

Squeezelite-ESP32 fails to run when LEDVU is enabled without a display.

The SETD message sends 0 in the display sizes followed by the ledvu strip length. The current code ignores this and still enables display control. The subsequent grfe messages cause a divide-by-zero error in the esp32 code. (other grf messages would also cause issues)

Can we add an additional check to disable render messages if the height (and/or width) is zero?. I can help if needed.

@marcelveldt
Copy link
Collaborator

Ah yeah, that part was so badly documented that I just guessed something - I'll make the adjustment, thanks for the tip

JamiePhonic pushed a commit to JamiePhonic/aioslimproto that referenced this issue Aug 24, 2024
JamiePhonic pushed a commit to JamiePhonic/aioslimproto that referenced this issue Aug 24, 2024
JamiePhonic pushed a commit to JamiePhonic/aioslimproto that referenced this issue Aug 24, 2024
Disable display if width/height are 0. Should fix home-assistant-libs#331
@JamiePhonic
Copy link
Contributor

Hi @wizmo2
I submitted a PR (#364) that should fix this issue.
Not sure how long it'll take for it to make it into mainline releases but you can clone this Repo and use the test script to verify. I didn't have any Addressable LED's kicking around to be able to test it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants