-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing check for zero height display on Squeezelite-ESP32 #331
Comments
Ah yeah, that part was so badly documented that I just guessed something - I'll make the adjustment, thanks for the tip |
JamiePhonic
pushed a commit
to JamiePhonic/aioslimproto
that referenced
this issue
Aug 24, 2024
should resolve home-assistant-libs#331
JamiePhonic
pushed a commit
to JamiePhonic/aioslimproto
that referenced
this issue
Aug 24, 2024
should resolve home-assistant-libs#331
JamiePhonic
pushed a commit
to JamiePhonic/aioslimproto
that referenced
this issue
Aug 24, 2024
Disable display if width/height are 0. Should fix home-assistant-libs#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Squeezelite-ESP32 fails to run when LEDVU is enabled without a display.
The SETD message sends 0 in the display sizes followed by the ledvu strip length. The current code ignores this and still enables display control. The subsequent
grfe
messages cause a divide-by-zero error in the esp32 code. (othergrf
messages would also cause issues)Can we add an additional check to disable render messages if the height (and/or width) is zero?. I can help if needed.
The text was updated successfully, but these errors were encountered: