Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder ignoring --test arg in BUILD_ARGS #207

Open
ChrisRomp opened this issue Jul 6, 2024 · 1 comment
Open

Builder ignoring --test arg in BUILD_ARGS #207

ChrisRomp opened this issue Jul 6, 2024 · 1 comment

Comments

@ChrisRomp
Copy link

ChrisRomp commented Jul 6, 2024

On push to main the CI is attempting to upload the image to a Docker repository, but my add-on builds locally so I don't store the built images. This used to work but one of the updates Dependabot helpfully added for the Builder action caused it to not work on my latest release (I haven't released in a while, so I'm not sure at which version this changed).

Expected result: Having --test in BUILD_ARGS would cause the Action to not try and upload the image.

Here's my CI YAML (truncated -- full config is here ):

name: Builder

env:
  BUILD_ARGS: "--test"
  MONITORED_FILES: "build.yaml config.yaml Dockerfile app"

...

      - name: Build ${{ matrix.addon }} add-on
        if: steps.check.outputs.build_arch == 'true'
        uses: home-assistant/[email protected]
        with:
          args: |
            ${{ env.BUILD_ARGS }} \
            --${{ matrix.arch }} \
            --target /data/${{ matrix.addon }} \
            --image "${{ steps.check.outputs.image }}" \
            --docker-hub "ghcr.io/${{ github.repository_owner }}" \
            --addon

The error at the end of the build:

[04:38:11] INFO: Finish build for ghcr.io/chrisromp/null:1.0.1
[04:38:11] INFO: Create image tag: latest
[04:38:11] INFO: Start upload of ghcr.io/chrisromp/null:1.0.1 (attempt #1/3)
[04:38:11] WARNING: Upload failed on attempt #1
[04:38:41] INFO: Start upload of ghcr.io/chrisromp/null:1.0.1 (attempt #2/3)
[04:38:41] WARNING: Upload failed on attempt #2
[04:39:11] INFO: Start upload of ghcr.io/chrisromp/null:1.0.1 (attempt #3/3)
[04:39:11] FATAL: Upload failed on attempt #3
Error: Process completed with exit code 1.
@agners
Copy link
Member

agners commented Aug 12, 2024

I wasn't able to reproduce the issue, and at least when looking at this log it seems to work with the linked config (v1.0.1)? 🤔
https://github.com/ChrisRomp/addon-ecowitt-proxy/actions/runs/9816631174/job/27107067878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants