Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solaredge hangs startup when requests fail to timeout #115588

Closed
bdraco opened this issue Apr 14, 2024 · 4 comments · Fixed by #115599
Closed

solaredge hangs startup when requests fail to timeout #115588

bdraco opened this issue Apr 14, 2024 · 4 comments · Fixed by #115599

Comments

@bdraco
Copy link
Member

bdraco commented Apr 14, 2024

The problem

There is no timeout passed to requests in the underlying library

Screenshot 2024-04-14 at 12 09 45 PM

There is an upstream issue but its years old bertouttier/solaredge#2

It looks like the lib is abandoned

What version of Home Assistant Core has the issue?

dev

What was the last working version of Home Assistant Core?

dev

What type of installation are you running?

Home Assistant OS

Integration causing the issue

solaredge

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@bdraco bdraco changed the title solaredge hangs startup when requests timeout solaredge hangs startup when requests fail to timeout Apr 14, 2024
@home-assistant
Copy link

Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (solaredge) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of solaredge can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign solaredge Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


solaredge documentation
solaredge source
(message by IssueLinks)

@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2024

The github repo doesn't match the pypi code either

@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2024

There are memory leaks in the library as well

@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2024

__init__.py:            api.get_details, entry.data[CONF_SITE_ID]
config_flow.py:            response = api.get_details(site_id)
coordinator.py:            data = self.api.get_overview(self.site_id)
coordinator.py:            data = self.api.get_details(self.site_id)
coordinator.py:            data = self.api.get_inventory(self.site_id)
coordinator.py:            data = self.api.get_energy_details(
coordinator.py:            data = self.api.get_current_power_flow(self.site_id)

All of these are tiny JSON endpoint wrappers.

I think its would be simple enough to make a new library with the same api (asyncio instead though)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants