Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecovacs integration not showing work mode for T20e omni #128735

Closed
bakerboy908 opened this issue Oct 19, 2024 · 7 comments
Closed

Ecovacs integration not showing work mode for T20e omni #128735

bakerboy908 opened this issue Oct 19, 2024 · 7 comments

Comments

@bakerboy908
Copy link

The problem

The integration should have an option for workmode for the T20e, currently the integration runs a mop and vac cycle, but there should be options for, vac only, mop only, vac and mop, vac then mop

What version of Home Assistant Core has the issue?

core-2024.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

ecovacs

Link to integration documentation on our website

https://www.home-assistant.io/integrations/ecovacs/

Diagnostics information

config_entry-ecovacs-01JABS0G1Q2M7FA688GCNQ3F5S.json

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @mib1185, @edenhaus, @Augar, mind taking a look at this issue as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


ecovacs documentation
ecovacs source
(message by IssueLinks)

@mib1185
Copy link
Contributor

mib1185 commented Oct 27, 2024

It seems you bot is not fully supported by the deebot_client lib. You need to add (or ask for it to be added) to the deebot_clien lib.

@bakerboy908
Copy link
Author

I believe the work mode was added with this pull request,
DeebotUniverse/Deebot-4-Home-Assistant#449

from what i can tell the functionality for the t20 and t20e have been symbolically linked

@mib1185
Copy link
Contributor

mib1185 commented Oct 31, 2024

DeebotUniverse/Deebot-4-Home-Assistant#449

this was the old custom integration, but not the deebot_clien library.

@bakerboy908
Copy link
Author

Sorry its very confusing, the link to the issues you posted has link to the old debot_client
This file has the capabilities linked to the t20
deebot_client/hardware/deebot/9ku8nu.py

here in the t20 file the capabilities
https://github.com/DeebotUniverse/client.py/blob/dev/deebot_client/hardware/deebot/p1jij8.py
Line 119 has the stuff related to work mode

The code is on the main branch and dev branch.

How can i check what version of the library the official integration is using?

@bakerboy908
Copy link
Author

As far as i can tell the integration is using deebot_client 8.0, i downloaded the source for that release and it does have the work mode capabilities for my bot

@edenhaus
Copy link
Contributor

This is a feature request. Feel free to add the work mode to your model in the library, and then it will also show up in HA.

Closing this issue here as we track only bugs with GitHub issues.

@edenhaus edenhaus closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants