-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samsung purposefully broke SmartThings integration on Dec 30 #133623
Comments
Hello. I confirm the above! Today my token stopped working, I created a new one and when registering access (on the Samsung website) a notification appeared that access was created for an hour! What should I do? |
This aligns with what I am seeing. Currently popping open the |
I'm trying to look into this but it doesn't look like we can use our normal oauth flow. |
Whew who ever gets SmartThings to stop giving me rate limits and doesn't make me get a new PAT every 24 hours will be my hero. Sure you guys have seen it but here's their documentation on the OAuth flow: https://developer.smartthings.com/docs/connected-services/oauth-integrations |
I am an old user of PAT. I restored from backup with mandatory new PAT. Now all my ST integration expired after 24 hours. Any progress for OAuth developement? |
Any word on the OAuth ? Half of my automations break every day due to an invalid token issue |
I recommend you make a new thread here: https://community.smartthings.com/latest |
Why would I make a thread there? This is an issue with Home Assistant using PATs vs the OAuth method SmartThings wants people to use.... SmartThings has made the change and are not going back, this has to be changed on the home assistant integration side |
Also encountered this problem. Besides the short TTL i can only issue 1 commnd in 20 seconds due to rate limiting. |
After PAT expire, HA get data only from read-only entities. I cannot execute actions. This is valid only If you do not restart HA. Temperature sensors values are correct. Strange ! |
So after a small bit of investigation, I If you look closely, the type of grant being used is If my assumptions are correct, there's an additional problem, this repository has been archived on May 9, 2024. I don't know if there's an additional fork of this repository that is being supported. |
I wasn't aware of this and it coincided with me finally tidying up my SmartThings devices with the hass-smarthings-remove script. I thought I'd borked the integration by doing that. Subscribed to this thread to see when a solution drops. It's a major impact for me as my front door lock is connected via SmartThings to add redundancy (if I can't unlock with Home Assistant, I can fall back on SmartThings) but my family all use HA exclusively. |
Interested in seeing what the solution to this will be ... |
@joostlek 4% of the community are using this integration (and it is a key feature of NabuCasa). Is there any timeline to fix this problem ? |
Why would it be a key feature of nabu casa? We're still looking into but trust me, it's difficult. I don't have any timeline as for now |
@joostlek one of the reasons why I'm using NabuCasa is because the integration with Amazon and Smartthings was made easy. And thank you for taking a crack at it ! |
@Jens-Wymeersch I recommend moving away from Samsung products and SmartThings, they broke this on purpose despite having received plenty of warning. |
@NewsGuyTor we have in total 7 A/Cs - 6 of the 7 are controlled locally but one with smartthings. I'm not planning to replace these devices in the near future (cost is way too high). |
For some reason, integration over PAT has been working for me for the last two or three days. I have not noticed any changes in the integration itself, and I was also unable to find any changes on Samsung's side (using community.smartthings). Any idea what is happening? |
@snok3r-krk Interesting, I've just recreated a PAT to test this, and at least the very strict API limits are not there right now (was like 1 request / minute?). Will have to wait to see if it has longer TTL too, or if they just relaxed the limits. |
ST reversed their decision temporarily for those with legacy PAT. All users who did not delete and create a new PAT should be good until HA fixes with OAUTH. |
@joostlek the call service is called climate.set_hvac_mode and data as indicated
the other command should be something like climate.set_temperature and the data should be something like
now in the last case, it should recognize the last mode and start it up like that |
The commands we send to SmartThings work a bit differently, we have to pass stuff in a list to them rather than key: value |
I just found out that air purifiers are seen as fans, so if you happen to have one of those feel free to help out :) |
@joostlek I understand but if I look at your log - which I'm not getting by the way. |
I have no clue why it doesn't show. But I know for sure that my actions work for my curtains and lights. I am now syncing my codebase with the official documentation, after that I will take a look |
I've got thermostats for you. I'll run the directions today and get you the info. |
Oh that is awesome! I could only test those via a virtual device so far, so in theory you should see every device like normal, but the test data is very much welcome :) |
Alright should be in your inbox. Hope this helps! |
@Jens-Wymeersch How are you observing the logs by the way? Are you downloading them or seeing them in System -> Logs? Because in the latter, it doesn't show debug ones in the UI, only if you download the logs |
@joostlek I was looking in the UI. Thanks for the hint Here are the logs from the custom integration for a change from 21 to 24C and change mode to heat → this didn't do anything
I ran similar commands in the current integration (debug mode), here are the logs
|
@joostlek I have both integrations now running simultaneously in 2 home assistant instances. So I can do any commands you want me to do and check the output. Let me know |
I created a new login flow for ioBroker maybe this relevant if Smartthings will not offer a new official way. |
@TA2k please send more info of how you are getting the ioBroker, SmartThings and home assistant working together |
@Jens-Wymeersch Do you have Discord, maybe its easier to do this in a chat than here, since I believe everyone gets an email for every message here :) |
@joostlek agreed and sorry. The info I provided was what you were looking for ? |
Yes, but let's continue in discord for now :) |
I have just sent you an email with my diagnostics and screenshots. I have two shades, which were treated as "covers" in the past. If you have already received enough of those, you may disregard the information from me. I also have a Frame TV, but I believe you have that covered already. Please let me know if there is anything I can help with! Interestingly, I have a second PA token for the "SamsungTV Smart" HACS integration, which I use for additional control of my Frame TV. I have not had to renew the PA token for that integration. I don't understand why it would be different, so it definitely seems like the HA built-in integrations tokens are being specifically targeted to expire every 24 hours. |
Tokens created before 30 december, not HA specifically |
All of my current tokens in ST were created after December 30th. The "SamsungTV Smart" token was actually my newest token when this problem cropped up for me in HA. My current "SamsungTV Smart" token is probably less than 10 days old. |
I have no clue then, fwiw they have this enforced everywhere. Thanks for the fixtures by the way :) |
Currently the last thing I am looking for is test data for a fan/humidifier/air purifier, so if you happen to have one, lmk! |
Aight, again, thanks for all the test data and responses from you all, it has been very helpful and it helped me a ton. Looking at the data, there's a lot of potential for features and neat stuff. So I just created a different Discord server so we can keep track of the data and devices, so we can make sure that if we implement a feature for for example a soundbar, that it works for all the users with a soundbar. So if you want to have even more features in the future (next to a working integration of course), join https://discord.gg/qEf4UWEq. Also, Please don't run the script again to download the integration as a custom component. I now implemented OAuth and that seems to work. My next tasks is cleaning up the code, and preparing for the final piece. I am still looking for the air purifier, so if you happen to have one, feel free to hmu! |
Is there any indication when version using oauth and replacing PAT will be released? |
My gues I missed something. |
You should have read the first hundred rather than notifying everyone on the thread you couldn't be bothered. I'm pretty sure it was said early the api changed from a key / value to a list or something to that effect. |
@harvey251 didn't you drink your coffee yet bro?
any way, here's another notification. |
@Jurgen-DOUCHY I've had coffee now ... basically it means that not only the authentication method has changed, but also how you interact with smart things. So I suspect a bigger job than you might initially expect. |
“Poor communications and inadequate notice to all interested parties about the change. This needs to be grandfathered with something like 3-6 months notice. Samsung should reverse the PAT change! Allow the community to transition on an orderly basis, anything less than this is shortsighted and interpreted as uncaring and undiplomatic.” Posted this at [Changes To Personal Access Tokens (PAT)] If a fix was easy it would be done already. Guys we have to make some noise |
The developer has been extremely active in this thread and a revamp of the integration to use oauth with refresh tokens as well as the different API, is nearly complete from the sound of it. I don't think trying to petition Samsung to change their token policy would be even worth thinking about at this point. |
The problem
https://community.smartthings.com/t/changes-to-personal-access-tokens-pat/292019
TLDR: Newly generated PATs will only work for 24 hours, which will be absurdly annoying for new users of this integration, so a change to OAuth auth is needed ASAP.
What version of Home Assistant Core has the issue?
NA
What was the last working version of Home Assistant Core?
NA
What type of installation are you running?
Home Assistant OS
Integration causing the issue
No response
Link to integration documentation on our website
No response
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: