-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recorder thread dies after exception from long query, after installing a theme. #31651
Comments
EDIT: the 403 error was due to an IP ban for some reason. So that is not related to the issue. |
themes data should not be sent over the event bus 🤦♂ (we also shouldn't crash the recorder) |
@basnijholt why do you have base64 encoded images in your theme? That is very inefficient. Just ask users to install an image in their |
What exception is thrown by the recorder? There should be a stacktrace to indicate the process has quit. |
It was recommended to do it this way by @ludeeus. I guess because it's easier to install with HACS. |
By having the images inside the themes, it makes it slower to load the themes on initial load of the app. If it was a url, themes load faster, get applied faster and the url can be loaded from cache. We should see if HACS can fix that. |
@recklessnl your issue claims that the recorder thread dies, however I cannot see that in the code. The fact that we log "Error saving event" means we caught the error. https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/recorder/__init__.py#L390-L392 Are there 0 events recorded after the error? And if so, do you see other errors ? |
I copied the title from the previous bug report. These are all the errors I see after the recorder error I posted earlier:
|
My question has not been answered. How do you know the recorder has died ? Nothing in your log indicates that the recorder has died? |
This is the answer: I copied the title from the previous bug report. You requested to make a new bug report, I just copied the title. Perhaps it didn't die. |
Okay, then the themes related PRs have fixed this issue. |
The problem
I installed a popular iOS dark theme from @basnijholt using HACS. It worked for a while, but suddenly now I'm getting 403 forbidden errors after rebooting Home Assistant Core (run through Docker). Turns out it's something to do with a base64 image producing incredibly long strings, that seems to overload my MariaDB database. It renders Home Assistant completely useless as I'm unable to even see the GUI. See log below. This is a continuation of #15984 per @balloob's request.
I'm not the only one with this issue: basnijholt/lovelace-ios-dark-mode-theme#6
Environment
Problem-relevant
configuration.yaml
Traceback/Error logs
Additional information
I removed the rest of the string as it was incomprehensible long... perhaps @basnijholt can help explain further what is going on since I don't know much about base64 images. I just want to make sure my database isn't corrupted by this.
The text was updated successfully, but these errors were encountered: