Error in jewish_calendar integration - Python Math ValueError thrown?

[NickInManchester]

The problem

For the integration author: Tsvi Mostovicz @tsvi
Also see: https://community.home-assistant.io/t/error-in-jewish-calendar-integration-python-math-valueerror-thrown/314289

At startup the "jewish_calendar" integration throws a Python Math ValueError exception many times but always in the same bit of code.

I'm running HA 2021.6.3 on a 4GB Raspberry PI4 using the standard integrated Home Assistant Operating System variant.

Version	core-2021.6.3
Installation Type	Home Assistant OS
Development	false
Supervisor	true
Docker	true
Virtual Environment	false
Python Version	3.8.9
Operating System Family	Linux
Operating System Version	5.4.83-v8
CPU Architecture	aarch64
Timezone	Europe/London

The error is logged as follows:

What is version of Home Assistant Core has the issue?

core-2021.6.3

What was the last working version of Home Assistant Core?

core-2021.6.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

jewish_calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/jewish_calendar/

Example YAML snippet

From configuration.yaml

jewish_calendar:
   language: english
   diaspora: true
   candle_lighting_minutes_before_sunset: 18
   havdalah_minutes_after_sunset: 0
#   latitude: 53.480759
#   longitude: -2.242631

Anything in the logs that might be useful for us?

Update for sensor.jewish_calendar_upcoming_havdalah_3 fails
8:54:14 PM – (ERROR) components/jewish_calendar/sensor.py - message first occurred at 5:05:14 PM and shows up 459 times
Update for sensor.jewish_calendar_upcoming_candle_lighting_3 fails
8:54:14 PM – (ERROR) components/jewish_calendar/sensor.py - message first occurred at 5:05:14 PM and shows up 459 times
Update for sensor.jewish_calendar_upcoming_shabbat_havdalah_3 fails
8:54:14 PM – (ERROR) components/jewish_calendar/sensor.py - message first occurred at 5:05:14 PM and shows up 459 times
Update for sensor.jewish_calendar_upcoming_shabbat_candle_lighting_3 fails
8:54:14 PM – (ERROR) components/jewish_calendar/sensor.py - message first occurred at 5:05:14 PM and shows up 459 times
Update for sensor.jewish_calendar_mincha_gedola_3 fails
8:54:14 PM – (ERROR) components/jewish_calendar/sensor.py - message first occurred at 5:05:14 PM and shows up 5049 times
=======================================================================
Just 1 of these many examples:

Logger: homeassistant.helpers.entity
Source: components/jewish_calendar/sensor.py:184
First occurred: 5:05:14 PM (459 occurrences)
Last logged: 8:54:14 PM

Update for sensor.jewish_calendar_upcoming_havdalah_3 fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 350, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 558, in async_device_update
    raise exc
  File "/usr/src/homeassistant/homeassistant/components/jewish_calendar/sensor.py", line 100, in async_update
    self._state = self.get_state(daytime_date, after_shkia_date, after_tzais_date)
  File "/usr/src/homeassistant/homeassistant/components/jewish_calendar/sensor.py", line 184, in get_state
    return times.havdalah
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 186, in havdalah
    return self._havdalah_datetime
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 162, in _havdalah_datetime
    return self.zmanim["sunset"] + dt.timedelta(minutes=self.havdalah_offset)
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 130, in zmanim
    for key, value in self.utc_zmanim.items()
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 122, in utc_zmanim
    for key, value in self.get_utc_sun_time_full().items()
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 313, in get_utc_sun_time_full
    first_light = self._get_utc_time_of_transit(106.1, True)
  File "/usr/local/lib/python3.8/site-packages/hdate/zmanim.py", line 295, in _get_utc_time_of_transit
    return self._datetime_to_minutes_offest(astral.sun.time_of_transit(
  File "/usr/local/lib/python3.8/site-packages/astral/sun.py", line 343, in time_of_transit
    hourangle = hour_angle(
  File "/usr/local/lib/python3.8/site-packages/astral/sun.py", line 243, in hour_angle
    HA = acos(h)
ValueError: math domain error

Additional information

No response

[probot-home-assistant]

jewish_calendar documentation
jewish_calendar source
_{^{(message by IssueLinks)}}

[tsvi]

@yuvalabou it's unrelated to the offset.
It has to do with certain latitudes (too much north or south) that will cause the calculations to reach extremities. We need to guard before sending the calculations to astral.

[NickInManchester]

I vaguely remember some of the Circadian lighting algorithms having similar problems in the past with people in Northern Canada where everything was tested on USA latitudes. But could not find it again. I generate times and a local calendar for our community. For this I use a mixture of the open-source hdate and other programmes. hdate in PiPi is based on libhdate on sourceforge at https://sourceforge.net/p/libhdate/wiki/Home/ I know this produces usable shabbat etc. numbers for our latitude at 53 North. Sorry, but I've not used astral knowingly before. *But see:* *sffjunkie/astral#67 <sffjunkie/astral#67>* from 28th March 2021 - same or similar problem. Nick

…

On Wed, 9 Jun 2021 at 08:15, Tsvi Mostovicz ***@***.***> wrote: @yuvalabou <https://github.com/yuvalabou> it's unrelated to the offset. It has to do with certain latitudes (too much north or south) that will cause the calculations to reach extremities. We need to guard before sending the calculations to astral. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51641 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6CDD7ZIVTTDZ2MFUO2D4TTR4IHNANCNFSM46KUADVA> .

-- Nick Filer 15 Ravensway Prestwich Manchester M25 0EU *Email*: ***@***.***

[NickInManchester]

Also see: sffjunkie/astral#64 These are for extreme case of Polar situation so much further North than my case. Nick

…

On Wed, 9 Jun 2021 at 08:15, Tsvi Mostovicz ***@***.***> wrote: @yuvalabou it's unrelated to the offset. It has to do with certain latitudes (too much north or south) that will cause the calculations to reach extremities. We need to guard before sending the calculations to astral. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

-- Nick Filer 15 Ravensway Prestwich Manchester M25 0EU Email: ***@***.***

[github-actions]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[NickInManchester]

Seems thave been resolved. Please close.

Thanks