From f8d25601046179540976d6c16e513749b519c526 Mon Sep 17 00:00:00 2001 From: Wendelin <12148533+wendevlin@users.noreply.github.com> Date: Tue, 28 Jan 2025 16:53:57 +0100 Subject: [PATCH] Revert "Add shortcut hint to assist dialog" (#23918) Revert "Add shortcut hint to assist dialog (#23739)" This reverts commit d121b332635f5073adb355ea44f863a7193d0f18. --- .../voice-command-dialog/ha-voice-command-dialog.ts | 12 +----------- .../show-ha-voice-command-dialog.ts | 2 -- src/panels/lovelace/hui-root.ts | 7 +------ 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/src/dialogs/voice-command-dialog/ha-voice-command-dialog.ts b/src/dialogs/voice-command-dialog/ha-voice-command-dialog.ts index 6717a6860a12..111dbcb0b6fc 100644 --- a/src/dialogs/voice-command-dialog/ha-voice-command-dialog.ts +++ b/src/dialogs/voice-command-dialog/ha-voice-command-dialog.ts @@ -29,7 +29,6 @@ import { haStyleDialog } from "../../resources/styles"; import type { HomeAssistant } from "../../types"; import { documentationUrl } from "../../util/documentation-url"; import type { VoiceCommandDialogParams } from "./show-ha-voice-command-dialog"; -import "../../components/ha-tip"; @customElement("ha-voice-command-dialog") export class HaVoiceCommandDialog extends LitElement { @@ -52,8 +51,6 @@ export class HaVoiceCommandDialog extends LitElement { @state() private _errorLoadAssist?: "not_found" | "unknown"; - @state() private _hint?: string; - private _startListening = false; public async showDialog( @@ -71,7 +68,6 @@ export class HaVoiceCommandDialog extends LitElement { this._startListening = params.start_listening; this._opened = true; - this._hint = params.hint; } public async closeDialog(): Promise { @@ -189,9 +185,6 @@ export class HaVoiceCommandDialog extends LitElement { size="large" > `} - ${this._hint - ? html`${this._hint}` - : nothing} `; } @@ -254,7 +247,7 @@ export class HaVoiceCommandDialog extends LitElement { css` ha-dialog { --mdc-dialog-max-width: 500px; - --mdc-dialog-max-height: 550px; + --mdc-dialog-max-height: 500px; --dialog-content-padding: 0; } ha-dialog-header a { @@ -319,9 +312,6 @@ export class HaVoiceCommandDialog extends LitElement { margin: 0 24px 16px; min-height: 399px; } - ha-tip { - padding-bottom: 16px; - } `, ]; } diff --git a/src/dialogs/voice-command-dialog/show-ha-voice-command-dialog.ts b/src/dialogs/voice-command-dialog/show-ha-voice-command-dialog.ts index e027839d7ef9..2ac41a5d9a73 100644 --- a/src/dialogs/voice-command-dialog/show-ha-voice-command-dialog.ts +++ b/src/dialogs/voice-command-dialog/show-ha-voice-command-dialog.ts @@ -6,7 +6,6 @@ const loadVoiceCommandDialog = () => import("./ha-voice-command-dialog"); export interface VoiceCommandDialogParams { pipeline_id: "last_used" | "preferred" | string; start_listening?: boolean; - hint?: string; } export const showVoiceCommandDialog = ( @@ -32,7 +31,6 @@ export const showVoiceCommandDialog = ( pipeline_id: dialogParams.pipeline_id, // Don't start listening by default for web start_listening: dialogParams.start_listening ?? false, - hint: dialogParams.hint, }, }); }; diff --git a/src/panels/lovelace/hui-root.ts b/src/panels/lovelace/hui-root.ts index eb621a9648fb..8a56f7a9cfe3 100644 --- a/src/panels/lovelace/hui-root.ts +++ b/src/panels/lovelace/hui-root.ts @@ -730,12 +730,7 @@ class HUIRoot extends LitElement { } private _showVoiceCommandDialog(): void { - showVoiceCommandDialog(this, this.hass, { - pipeline_id: "last_used", - hint: this.hass.enableShortcuts - ? this.hass.localize("ui.tips.key_a_hint") - : undefined, - }); + showVoiceCommandDialog(this, this.hass, { pipeline_id: "last_used" }); } private _handleEnableEditMode(ev: CustomEvent): void {