Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Economizer: implement Swing visualization combined with Zone #244

Closed
climategadgets opened this issue Oct 12, 2022 · 1 comment
Closed

Economizer: implement Swing visualization combined with Zone #244

climategadgets opened this issue Oct 12, 2022 · 1 comment
Labels
enhancement process control reactive-only Will be fixed in Reactive branches only usability UX visualization
Milestone
Implement the eco...

Comments

@climategadgets
Copy link
Member

climategadgets commented Oct 12, 2022 •
edited
Loading

Reference: HVAC Device: Economizer
Depends on: #239

Acceptance Criteria

  • Zone panel/cell pair displays zone status against the following variables in a way consistent with the display in the case when Economizer is not configured:
    • Indoor temperature
    • Setpoint
    • Changeover delta
    • Target temperature
    • Ambient temperature
  • Zone panel allows to control changeover delta, target temperature, keep HVAC running on/off, and economizer enabled/disabled state along with currently existing zone controls

Update: requirement to have economizer controls in the same UI element as zone controls would cause control scheme to be too complicated and confusing. Controls will have to go to an independent panel (see #239)
@climategadgets climategadgets mentioned this issue Oct 21, 2022
Open
climategadgets added a commit that referenced this issue Oct 22, 2022
@climategadgets
Documentation update (#244)
b58f875
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Code review, trivial refactoring (#244)
87295da
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Trivial performance improvement on startup (#244)
d5a13be
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Code review, trivial refactoring (#244)
44b392e
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Split Averager into abstract and concrete classes to reuse code for e…
d44fed2 
…conomizer samples (#244)
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Renamed a class to reflect its updated purpose (#244)
2ca36bb
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Updated *Averager to be able to work with ZoneChartDataPoint (#244)
cb588d9
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Propagated EconomizerStatus to the zone chart (#244)
8be9650
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Renamed the lock, moved dsSetpoints.append() into its scope (#244)
5abec5d
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Renamed TintedValue to prepare for extension (#244)
e316fe5
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Added EconomizerTintedValue and the averager for it (#244)
2629a9d
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Checkpoint: adding economizer outptu to zone panel (#244)
f4bf595
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Revert "Trivial performance improvement on startup (#244)"
f997500 
This reverts commit d5a13be, it was more
complicated than it seemed.
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Fixed Freudian slip; dodged NPE on no economizer data (#244)
ba9d495
climategadgets added a commit that referenced this issue Apr 19, 2023
@climategadgets
Now drawing the economizer target temp - but need to correct autoscal…
0046f88 
…ing (#244)
climategadgets added a commit that referenced this issue Apr 20, 2023
@climategadgets
Checkpoint: now drawing target temp and ambient on the zone chart (#244)
c39655a 
Ambient and economizer signal visualizations are wrong, next commit will fix
that.
climategadgets added a commit that referenced this issue Apr 23, 2023
@climategadgets
Now drawing the thermostat and ambient signals with correct colors (#244
c9875fd 
)
climategadgets added a commit that referenced this issue Apr 23, 2023
@climategadgets
Now drawing the ambient semi-transparent (#244)
5a4653c
climategadgets added a commit that referenced this issue Apr 23, 2023
@climategadgets
Adjusted economizer colors not to clash with existing (#244)
f4116c8
climategadgets added a commit that referenced this issue Apr 26, 2023
@climategadgets
Merge branch 'gh244-swing-eco' into reactive (#244)
7d0fc55
@climategadgets
Copy link
Member Author

climategadgets commented Apr 27, 2023 •
edited
Loading

First usable draft complete as of rev. 7d0fc55 05eaafa. Will evolve; watch #239 for updates.

climategadgets added a commit that referenced this issue Apr 27, 2023
@climategadgets
Dodged NPE on absent economizer for the zone (#244)
05eaafa
climategadgets added a commit that referenced this issue Apr 27, 2023
@climategadgets
Dropped log level for a message (#244)
20cb369
@climategadgets climategadgets mentioned this issue Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement process control reactive-only Will be fixed in Reactive branches only usability UX visualization
Projects
None yet
Milestone
Implement the economizer
Development

No branches or pull requests
1 participant
@climategadgets