Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in the spec are broken #28

Open
Tieske opened this issue Jul 6, 2024 · 2 comments · May be fixed by #29
Open

Links in the spec are broken #28

Tieske opened this issue Jul 6, 2024 · 2 comments · May be fixed by #29

Comments

@Tieske
Copy link
Contributor

Tieske commented Jul 6, 2024

The links in the spec now link to the main page, instead of the specification page. This causes all generated links to be broken.
@nstadigs
Copy link

nstadigs commented Nov 19, 2024 •
edited
Loading

It's because of the <base /> tag that was added here: https://github.com/homieiot/homieiot.github.io/pull/18/files#diff-8fbefdbf4ec8887cdcf8639ab7a743f0d5456631bd09957650094f0bb848c7dcR4

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base#in-page_anchors

It can either be removed or be changed to include the full path to the document

Tieske added a commit that referenced this issue Nov 19, 2024
@Tieske
fix(links): change base fore fragment resolution
98591d1 
fixes #28
@Tieske Tieske linked a pull request Nov 19, 2024 that will close this issue
Open
@Tieske
Copy link
Contributor Author

Tieske commented Nov 19, 2024

created a PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(links): change base for fragment resolution homieiot/homieiot.github.io
2 participants
@nstadigs @Tieske