Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Spans for jobs in multi-job flows #289

Open
fitz-vivodyne opened this issue Mar 26, 2024 · 0 comments
Open

Generate Spans for jobs in multi-job flows #289

fitz-vivodyne opened this issue Mar 26, 2024 · 0 comments
Labels
type: enhancement New feature or request

Comments

@fitz-vivodyne
Copy link

fitz-vivodyne commented Mar 26, 2024

Is your feature request related to a problem? Please describe.

I'm testing out the project on a multi-job workflow.
Following the documentation in the README appears to only create the init events.

This leaves you with a trace that only has a few sparse init events along a very empty timeline.

Describe the solution you'd like

Generate spans for each job within a multi-workflow build

Describe alternatives you've considered

Alternatively you could add manual instrumentation to each job in the workflow, but that adds more repetitive noise.

Additional context
It looks like the postRun code is only called if the trace is supposed to end:

if (!isPost) {
run()
} else if (isPost && endTrace) {
runPost()
}

I'm thinking there should always be a post run function to close a span, but conditionally close the trace.

@fitz-vivodyne fitz-vivodyne added the type: enhancement New feature or request label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant