Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict With KafkaJs #19

Closed
lcharbon opened this issue Jan 7, 2020 · 2 comments
Closed

Conflict With KafkaJs #19

lcharbon opened this issue Jan 7, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lcharbon
Copy link

lcharbon commented Jan 7, 2020

Importing grok-js to an app with kafkajs will break kafkajs. await producer.send() will fail and return an empty array.

See minimal example here.

In this example, if const grok = require('grok-js'); is uncommented kafkajs will stop working.

Issue submitted to kafkajs here.

@Nevon
Copy link

Nevon commented Jan 8, 2020

I debugged this a little bit and found that it's because grok-js depends on the collections library, which replaces Array.from with an implementation that doesn't work with iterables. I would recommend dropping collections as a dependency.

@honzahommer honzahommer added the bug Something isn't working label Jan 11, 2020
@honzahommer honzahommer self-assigned this Jan 11, 2020
@honzahommer
Copy link
Owner

honzahommer commented Jan 11, 2020

@lcharbon Please install latest release (https://www.npmjs.com/package/grok-js/v/3.3.0). For now fixed by fork (honzahommer/collections@394dd58).

@Nevon Thanks for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants