-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds packages, base parts 3D models for 6.3mm Resistors #304
base: master
Are you sure you want to change the base?
Conversation
Bot! |
This comment has been minimized.
This comment has been minimized.
Btw. the silkscreen error is expected here. The TH part goes on top of the silkscreen. This error will also happen with the TO-220-3 and similar packages. |
The same physical resistor is used for both horizontal and vertical parts, surely this should be a single base part with 2 alternate packages? |
Now that you mention it, it makes a lot of sense. These packages have been very old, so it might be that back then the alternate package mechanism was not implemented yet (or, equally likely: it was implemented, but I did not know about it back then). Anyways I fixed it here, and |
I remembered it the wrong way around, sorry : /
Bot! |
This review is brought to you by the Horizon EDA Poolbot commit eb40288. Items in this PR
Parts overview (excluding derived)Bold items are from this PR
Items not associated with any part
DetailsParts6.3mm Resistor Base Part✔️ Checks passed
Flags
PackagesGeneric Resistor 6.3 mm Length
✔️ Package checks passed Clearance checks didn't pass
Parameters
Pads
3D views (one model)Without model
resistor_6.3mm_length_8.75mm_lead_spacing.step
Pitch analysis
Generic Resistor 6.3 mm Length (Vertical)
✔️ Package checks passed Clearance checks didn't pass
Parameters
Pads
3D views (one model)Without model
resistor_6.3mm_length_2.54mm_lead_space_vertical.stp
Pitch analysis
|
|
As proposed by @carrotIndustries here I added the packages, 3D-models and base parts for 6.3mm through hole resistors (both horizontal and vertical orientations).
The base parts are actually altered variants of the ones I am using in my repo, as they have been including some Yageo-specific details. I
will adddid add these new base parts as the bases of my resistors-bases as well in order to make them compatible with the official pool.The 3D-models (as mentioned already in the original PR #48) have been modelled by myself. I was toying with the idea of writing a script to add colored stripes, but reached the conclusion that the amount of data this would add would not be worth it. People who want that kind of detail in their 3D-models are better served with using textures and Blender anyways.