From d3fcfc42f3bdd5d837b33a5cfe6d3aede2b34be1 Mon Sep 17 00:00:00 2001 From: HorstOeko Date: Tue, 28 Jan 2025 08:45:12 +0100 Subject: [PATCH] [ENH] #244 Make isFile() and xmlDataIsFile() methods overridable --- src/ZugferdDocumentPdfBuilderAbstract.php | 6 +----- src/ZugferdDocumentPdfMerger.php | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/ZugferdDocumentPdfBuilderAbstract.php b/src/ZugferdDocumentPdfBuilderAbstract.php index 2daf2e4..8b08043 100644 --- a/src/ZugferdDocumentPdfBuilderAbstract.php +++ b/src/ZugferdDocumentPdfBuilderAbstract.php @@ -667,11 +667,7 @@ protected function extractInvoiceInformations(): array */ protected function isFile($pdfData): bool { - try { - return is_file($pdfData) && !is_link($pdfData) && is_readable($pdfData); - } catch (Throwable $throwable) { - return false; - } + return is_file($pdfData); } /** diff --git a/src/ZugferdDocumentPdfMerger.php b/src/ZugferdDocumentPdfMerger.php index 6d4a7aa..9d33057 100644 --- a/src/ZugferdDocumentPdfMerger.php +++ b/src/ZugferdDocumentPdfMerger.php @@ -106,11 +106,7 @@ protected function getXmlAttachmentXmpName(): string */ protected function xmlDataIsFile(): bool { - try { - return is_file($this->xmlDataOrFilename) && !is_link($this->xmlDataOrFilename) && is_readable($this->xmlDataOrFilename);; - } catch (\TypeError $typeError) { - return false; - } + return is_file($this->xmlDataOrFilename); } /**