Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission count in infographics page is not updated when custom coordinate upload #1711

Open
manjitapandey opened this issue Jul 29, 2024 · 7 comments
Assignees
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:high Should be addressed as a priority testing:ready Ready for testing

Comments

@manjitapandey
Copy link
Collaborator

Describe the bug
When user uploads their submission using custom coordinate and not selecting any entities presented, this is not counted as the submission and is not updated on infographics page.
In the screenshot below, The submission count is shown 0 while the submission is available there in the table.
image

The form submission graphs also shows no form submitted.
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'project details page and scan the QR'
  2. Fill up the form by selecting custom coordinate
  3. view the infographics page.
  4. See error

Expected behavior
Is this the expected behavior? Needs further discussion on how to manage this inconsistency.
What would end users understand from the graph.
cc: @spwoodcock , @ramyaragupathy

@manjitapandey manjitapandey added the bug Something isn't working label Jul 29, 2024
@spwoodcock
Copy link
Member

spwoodcock commented Jul 29, 2024

Will probably address this next release 👍

Thanks for picking it up!

@manjitapandey
Copy link
Collaborator Author

What could be the possible solution to tackle with this inconsistency?

cc: @spwoodcock , @NSUWAL123 , @Sujanadh

@NSUWAL123
Copy link
Collaborator

NSUWAL123 commented Aug 2, 2024

The solution may be to revert back to the previous approach of calculating counts for the infographics using API or work on backend linking the custom coordinate with the building. This problem is due to the calculation of counts from the /statuses API. Since the submission is not linked with any OSM id, this problem is caused.
And is linking the custom coordinate with the building hard @spwoodcock ?

@spwoodcock
Copy link
Member

There is a solution in the XLSForms!

https://docs.getodk.org/central-entities/#creating-and-updating-entities-with-one-form

We can use the create_if field in the entities tab of the survey form to create an entity if a geopoint location is recorded.

Requirement:

  • Check that having a mixed polygon and point entity list won't break anything, e.g. the map widget in ODK Collect

@spwoodcock spwoodcock added priority:high Should be addressed as a priority backend Related to backend code effort:low Likely a few hours labels Aug 2, 2024
@spwoodcock
Copy link
Member

Blocked by #1730

@manjitapandey
Copy link
Collaborator Author

For reference:
The total submission count on submissions doesn't match with the actual submission count on table and total count on the pagination
image

@Sujanadh
Copy link
Collaborator

Sujanadh commented Sep 4, 2024

I will work on this @spwoodcock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:high Should be addressed as a priority testing:ready Ready for testing
Projects
Development

No branches or pull requests

4 participants